Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462982
--- Comment #4 from Jan ONDREJ ondrejj@salstar.sk 2008-09-20 12:01:49 EDT --- (In reply to comment #3)
(In reply to comment #1)
Fix "Source:" path. Your URL points to different URL like Source. I think your URL is OK, but you have to change Source to original path, not path to your local site.
BTW do I need to have a URL for the Source: Tag ? Can I just use the file name only ?
Yes, you need to have an URL and why do not use upstream URL? What is wrong with him?
Fix BuildRoot, use any of these: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag Your path is similar, but not same as described here.
You mean changing %(id -u -n) (which was a previous Fedora recommandation btw) or using mktemp ?
Select any from packaging guidelines. May be your version was good for older packages, current guidelines requires to select one of these on BuildRoot_tag page.
Other personal suggestions: 01-debian-patches.all.gz does not look as an Fedora patch. Please, can you rename it and remove debian specific parts?
It's jut a patch tha is in the Debian package, and that helps removing compiler warnings. Should it be named 01-gcc-waranings instead ?
Please ignore this my comment and see comment from Mamoru Tasaka. He is a better reviewer like me. :-) You should ignore my comment about this patch completely.
So you have to fix only: - license - source url path - buildroot