https://bugzilla.redhat.com/show_bug.cgi?id=2232847
Felix Wang topazus@outlook.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |topazus@outlook.com CC| |topazus@outlook.com Flags| |fedora-review? Status|NEW |ASSIGNED
--- Comment #4 from Felix Wang topazus@outlook.com --- Take this. Besides the above Tim's comments, Here are my comments.
1. It would be better to put the files in the -devel sub-package, like the wayland-protocols package, https://src.fedoraproject.org/rpms/wayland-protocols/blob/rawhide/f/wayland-...
2.
The %{name}-devel package contains libraries and header files for developing applications that use %{name}.
The description is not appropriate to express the package.
3.
BuildRequires: qt5-qtbase-devel
I see the CMake files in the project, it seems that the package do not have this build dependency.