https://bugzilla.redhat.com/show_bug.cgi?id=2051066
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jkadlcik@redhat.com Doc Type|--- |If docs needed, set a value
--- Comment #1 from Jakub Kadlčík jkadlcik@redhat.com --- Hello Aleksei, thank you for the package.
I tested it on X11 and it works for me.
I am not very familiar with the yambar project and C programming, so if you please can help me here - The licensecheck found following:
ISC License ----------- yambar/external/river-status-unstable-v1.xml
MIT License ----------- yambar/LICENSE
NTP License (legal disclaimer) Historical Permission Notice and Disclaimer - sell variant
----------------------------------------------------------------------------------------- yambar/external/wlr-foreign-toplevel-management-unstable-v1.xml yambar/external/wlr-layer-shell-unstable-v1.xml
Should we mention it in the License field?
- Sun Sep 12 2021 Aleksei Bavshin alebastr@fedoraproject.org - 1.7.0-0.1
- Mon Jul 26 2021 Aleksei Bavshin alebastr@fedoraproject.org - 1.6.2-0.1
The release number for older versions is unexpected. I don't see any reason why to deviate from the "Simple versioning" scheme here https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_simpl...
Use a Release: tag starting with 1 (never 0). Append the Dist Tag. Increment the release (by 1) for each update you make. Reset to 1 whenever you change Version:.
But those are older changelog entries, and the current release and changelog entry is correct, so I think we don't need to change anything here.
%doc README.md examples/*
Just a note (for me) - I wouldn't expect such example scripts in %doc, but other packages do this as well `find /usr/share/doc/ |grep ".sh$"` so it's probably okay :-)