https://bugzilla.redhat.com/show_bug.cgi?id=2149953
blinxen h-k-81@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |h-k-81@hotmail.com Flags| |fedora-review? CC| |h-k-81@hotmail.com
--- Comment #4 from blinxen h-k-81@hotmail.com --- Taking this review
Some comments / issues with the package:
- The upstream project does not include a license file in `Cargo.toml`. I can see that you add it manually but it would be nice if you could push the change to upstream. Maybe by specifying `license-file` [1]?. - The license path for the `devel` package is wrong. It should be `%license %{crate_instdir}/LICENSE`. - `rust2rpm` always adds the `%doc` directive to `devel` packages. I am not sure if this is actually required as I couldn't find anything about it in the guidelines but I think adding it shouldn't hurt. Something like `%doc %{crate_instdir}/README.md`
[1] https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-lice...