Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: acpid
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225237
------- Additional Comments From pknirsch@redhat.com 2007-02-07 06:52 EST ------- 1: Fixed Buildroot, add smp_flags. Also added the %{?dist} to the Release 2: Included doc files 3.1: Checked, all 3 should really be noreplace, fixed. 3.2: acpid can't be run as anything else but root, so there is no point in it being executable or readable by everyone. 3.3: acpid isn't a network/remote service, so enabling it by default is safe. Also even if a machine doesn't have ACPI (nowadays kinda rare, but still), making it default will be the best choice the the majority of systems. 3.4: Why is the premission for an initscript strange with 0755, even in a srpm? But fixed the PreReqs to use the correct modern style. 3.5: Added -q for %setup 4.1: Typical /var/log/FOO entry. The package itself doesn't package a real file, but "supports" one being there. See other /var/log logfile supporting packages. 4.2: Fixed. Also fixed all the /etc occurences with %{_sysconfdir} and /usr/share with %{_datadir} 4.3: Fixed.
Thanks for the review,
Read ya, Phil