https://bugzilla.redhat.com/show_bug.cgi?id=1074129
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #7 from Petr Pisar ppisar@redhat.com --- Spec file changes:
--- perl-Compress-LZF.spec.old 2014-03-12 11:00:35.000000000 +0100 +++ perl-Compress-LZF.spec 2014-04-10 13:17:32.000000000 +0200 @@ -8,6 +8,7 @@ URL: http://search.cpan.org/dist/Compress-LZF/ Source0: http://www.cpan.org/modules/by-module/Compress/Compress-LZF-%%7Bversion%7D.t... Patch1: compress_lzf_unbundle.patch +BuildRequires: liblzf-devel BuildRequires: perl BuildRequires: perl(DynaLoader) BuildRequires: perl(Exporter) @@ -16,12 +17,12 @@ Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
%description -This is Perl binding to the LZF compression library +This is Perl binding to the LZF compression library.
%prep %setup -q -n Compress-LZF-%{version}
-%patch1 +%patch1 -p1
%build %{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
The patch is good. Ok.
TODO: Append full-stop mark at the end of the %description.
-This is Perl binding to the LZF compression library +This is Perl binding to the LZF compression library. Ok.
FIX: You forgot to mention the lzf_c_best.c license in the License tag (because you still use it).
The lzf_c_best.c has been removed. Ok.
FIX: Build-require liblzf-devel.
+BuildRequires: liblzf-devel Ok.
TODO: I strongly recommend to delete the unbundled files in %prep section to make sure they will not be used for building.
Implemented in the patch. Ok.
FIX: You kept files (lzf_c_best.c) that come from libzf development sources (http://cvs.schmorp.de/liblzf/) and its dependency lzfP.h. This is still considered as a bundling. The best approach is to ask liblzf developers and maintainers to do a new release with these files. Otherwise you need to obtain exception from FPC. Alternatively you can remove support for the "best compression level" from LZF.xs.
The "best compression level" with lzf_c_best.c and lzfP.h have been removed. Ok.
All tests pass. Ok.
$ rpmlint perl-Compress-LZF.spec ../SRPMS/perl-Compress-LZF-3.7-1.fc21.src.rpm ../RPMS/x86_64/perl-Compress-LZF-* perl-Compress-LZF.x86_64: E: incorrect-fsf-address /usr/share/doc/perl-Compress-LZF/COPYING.GNU 3 packages and 1 specfiles checked; 1 errors, 0 warnings. rpmlint is Ok.
Package builds in F21 (http://koji.fedoraproject.org/koji/taskinfo?taskID=6739594). Ok.
Package is in line with Fedora and Perl packaging guidelines.
Resolution: Package APPROVED.