Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=456038
Brian Pepple bdpepple@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bdpepple@gmail.com AssignedTo|nobody@fedoraproject.org |bdpepple@gmail.com Flag| |fedora-review+
--- Comment #8 from Brian Pepple bdpepple@gmail.com 2008-10-12 00:20:49 EDT --- MD5Sum: 590c152cde2d62fef422f9f773560e95 darkice-0.19.tar.gz
Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Buildroot has all required elements * All paths begin with macros * Make succeeds even when %{_smp_mflags} is defined * Files have appropriate permissions and owners * Rpmlint produces only the following warning, which can be safely ignored: darkice.x86_64: W: conffile-without-noreplace-flag /etc/darkice.cfg * Package installs and uninstalls cleanly
Bad: * License should be GPLv2+, which you can fix when you import the package into CVS.
+1 APPROVED, and I'll also be you sponsor.