Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: ocamldsort - Dependency sorter for OCaml source files
https://bugzilla.redhat.com/show_bug.cgi?id=434704
panemade(a)gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
------- Additional Comments From panemade(a)gmail.com 2008-03-02 03:23 EST -------
Review:
+ package builds in mock (rawhide i386).
koji build =>
http://koji.fedoraproject.org/koji/taskinfo?taskID=483521
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
9651d6afb204c0b22cd69be8a847e1d4 ocamldsort-0.14.4.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.
APPROVED.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.