Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=583102
Ankur Sinha sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |sanjay.ankur@gmail.com AssignedTo|nobody@fedoraproject.org |sanjay.ankur@gmail.com Flag| |fedora-review?
--- Comment #1 from Ankur Sinha sanjay.ankur@gmail.com 2010-05-07 01:13:13 EDT --- hey,
a quick look.
## The python_sitelib definition could be changed to
http://fedoraproject.org/wiki/Packaging/Python#Macros
## The build section could use
CFLAGS="$RPM_OPT_FLAGS" %{__python} setup.py build
This way the correct flags are used.
## line 37 could use %{__python} instead of python (optional)
## %{python_sitelib}/radiotray-0.5.1-py?.?.egg-info would help not break the package in case of py version changes?
No major issues, I'll do a complete review within the coming week hopefully.
regards, Ankur