Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=727899
--- Comment #3 from Chris Lalancette clalance@redhat.com 2011-08-04 10:01:41 EDT --- (In reply to comment #1)
Issues: [!] : MUST - Rpmlint output is silent.
- as noted above, this doesn't seem to be regarded as a problem
Yeah, that happens with all ruby packages, due to the way that rdoc builds documentation files. This can be ignored.
- Overall, it looks okay to me but there seem to be some discrepancies with the
Ruby-specific guidelines at:
http://fedoraproject.org/wiki/Packaging/Ruby
e.g. it doesn't own %{gemdir}/gems/%{gemname}-%{version}/ and %prep isn't empty
- this may just be a matter of individual style
Actually, it does own %{gemdir}/gems/%{gemname}-%{version}; it's just that we use the macro %{geminstdir} to do that. %prep not being empty is due to the Fedora guidelines being out of date; the unofficial way we have been doing pure ruby rubygems lately is to put everything into %prep and %install. If you think about it, that makes sense; doing an "rpmbuild -bp <spec>" will then get you a tree that you can look at, even if it is hidden beneath a directory tree.
If the above all makes sense to you, can you set this to fedora-review+ ? Thanks!