Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Test-Spelling - Check for spelling errors in POD files
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220217
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From panemade@gmail.com 2006-12-20 01:55 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPMS. + source files match upstream. 1820e1248bf5dfba6139b6812a5f92ae Test-Spelling-0.11.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + %check used make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/load....ok t/pod.....ok All tests successful. Files=2, Tests=2, 0 wallclock secs ( 0.14 cusr + 0.02 csys = 0.16 CPU) + Provides: perl(Test::Spelling) = 0.11 + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Dose owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Followed perl packaging guidelines. APPROVED.