Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: alleyoop : Graphical front-end to the Valgrind memory checker for x86
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201417
------- Additional Comments From giallu@gmail.com 2006-10-02 10:48 EST ------- (In reply to comment #5)
- The desktop file has "Version=0.9.0". Should that be "Version=0.9.3" ?
Done. I'm not sure about the purpose of this field, though...
- You are using %makeinstall. Can you switch to 'make DESTDIR=..." ?
Done.
- Why %defattr(-,root,root,0755) instead of just %defattr(-,root,root,-).
Do some of the installed dirs get the wrong permissions?
This and the previous point was inherited from the original spec, so I'm not sure why it was that way. Changed
- Your desktop install should add:
--add-category X-Fedora
Done
- Doesn't build in mock. I get this at the end of build.log:
configure: error: *** libiberty required to build Alleyoop. error: Bad exit status from /var/tmp/rpm-tmp.34937 (%build)
Missing BuildRequires: binutils-devel?
Done
- Adding the BuildRequires from point 5, the package builds and
rpmlint says:
W: alleyoop conffile-without-noreplace-flag /etc/gconf/schemas/alleyoop.schemas
Should this be marked (noreplace)?
I asked for this info in #fedora-extras before, and I was told to leave it this way: e.g an update should also overwrite the schema. However, the full rationale for this is not clear to me
W: alleyoop macro-in-%changelog description W: alleyoop macro-in-%changelog postun
In changelog's you need to use %% to refer to a macro, or rpm will expand them.
Done
New spec and srpms at: http://giallu.interfree.it/fedora/alleyoop.spec http://giallu.interfree.it/fedora/alleyoop-0.9.3-2.src.rpm