https://bugzilla.redhat.com/show_bug.cgi?id=1011500
Lubomir Rintel lkundrak@v3.sk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|package-review@lists.fedora | |project.org |
--- Comment #2 from Lubomir Rintel lkundrak@v3.sk --- (In reply to Christopher Meng from comment #1)
BuildRequires: pkgconfig(dconf)
can be dconf-devel, no need to use pkgconfig everywhere.
config.tests/dconf/dconf.pro seems to use pkgconfig to locate the package. This is more robust.
Use github tag
I do (v0.1.0) and am not sure I understand what you really mean.
No license as %doc
Will fix.
Why
BuildRequires: qt5-qtbase-devel >= %{version} ??
The version? I copied it from another qt5 package. I'll remove that.