Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=475065
Martin Gieseking martin.gieseking@uos.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|alexl@users.sourceforge.net |martin.gieseking@uos.de Flag|fedora-review? |fedora-review+
--- Comment #27 from Martin Gieseking martin.gieseking@uos.de 2009-09-08 14:04:09 EDT --- Here comes the review.
$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm givaro.x86_64: W: shared-lib-calls-exit /usr/lib64/libgivaro.so.0.0.4 exit@GLIBC_2.2.5 givaro-devel.x86_64: W: no-documentation givaro-devel.x86_64: E: non-executable-script /usr/share/givaro/givaro-makefile 0644 /bin/sh givaro-static.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 1 errors, 3 warnings.
- call of exit() can be ignored according to comment #25 - missing docs in -devel and -static is OK - #!/bin/sh in makefile already removed according to comment #23
--------------------------------- keys used in following checklist:
[+] OK [.] OK, not applicable [X] needs work ---------------------------------
[+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. - GPLv2 boilerplates missing (upstream notified)
[+] MUST: The License field in the package spec file must match the actual license. [+] MUST: files containing the text of the license(s) must be included in %doc. - COPYING added to %doc of base package
[+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. - md5 hash is f0b754ee54bcac0e866f2979b57393ba
[+] MUST: The package MUST successfully compile and build into binary rpms. - builds in koji https://koji.fedoraproject.org/koji/taskinfo?taskID=1662967
[.] MUST: If the package does not successfully compile, ... [+] MUST: All build dependencies must be listed in BuildRequires [.] MUST: The spec file MUST handle locales properly. - no locales
[+] MUST: Packages containing .so files must call ldconfig in %post and %postun. - base package contains libgivaro.so.0.0.4 - ldconfig called in %post and %postun
[.] MUST: If the package is designed to be relocatable, ... - package not relocatable
[+] MUST: A package must own all directories that it creates. [+] MUST: A package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. - givaro-makefile contains #!/bin/sh that must be removed - already done according to comment #23
[+] MUST: %clean section must contain rm -rf %{buildroot}. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. - no large docs
[+] MUST: Files in %doc must not affect the runtime of the application. [+] MUST: Header files must be in a -devel package. [+] MUST: Static libraries must be in a -static package. - libgivaro.a
[.] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' - no .pc files
[+] MUST: .so without suffix must go in a -devel package. - libgivaro.so
[+] MUST: devel packages must require %{name} = %{version}-%{release} [+] MUST: Packages must NOT contain any .la libtool archives - .la file removed in %install
[.] MUST: Packages containing GUI applications must include a %{name}.desktop file - no GUI
[+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}. [+] MUST: All filenames in rpm packages must be valid UTF-8.
[+] SHOULD: The reviewer should test that the package builds in mock. - builds in mock
[+] SHOULD: The package should compile and build into binary rpms on all supported architectures. [+] SHOULD: The reviewer should test that the package functions as described. - I tested some of the functions provided by the library and they worked as expected - givaro-config prints the correct flags
[+] SHOULD: If scriptlets are used, those scriptlets must be sane. call of ldconfig in %post and %postun
[+] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. - subpackage -static requires base and -devel package - Requires: %{name} = %{version}-%{release} is redundant
------------------------ The package is APPROVED. ------------------------