https://bugzilla.redhat.com/show_bug.cgi?id=2074463
Maxwell G gotmax@e.email changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Flags| |fedora-review+ Assignee|nobody@fedoraproject.org |gotmax@e.email
--- Comment #5 from Maxwell G gotmax@e.email --- I am not going to go through the whole fedora-review template, as this package uses go2rpm.
- [x] The specfile is sane. - [x] License is correct - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No relevant rpmlint errors - [x] %check section passes - [-] The latest version is packaged This is a compat package. - [x] `%goipath` is set correctly - [-] Binaries don't conflict with binaries already in the distribution - [x] The package complies with the Packaging Guidelines.
Small nitpick:
If you'd like, you can also remove the numbers from Source0 and Patch0 (sed -e 's|Source0:|Source: |' -e 's|Patch0:|Patch: |' -i golang-gopkg-op-logging-1.spec) [1]. RPM has supported automatic source/patch file numbering since 4.15.x. The source numbers are not referenced anywhere in this specfile, so I don't see any good reason to keep them. I also submitted a PR to go2rpm to fix this.
[1]: The extra spaces are to keep the standard specfile indentation.
---
Package approved! On import, don't forget to do the following:
(I did the first three steps for you for your first two packages)
- [-] Add package to release-monitoring.org by doing. Normally, you'd want to do this, but we can skip this step for this specific package, as it's a compat package which deliberately does not include the latest version.
Here are the steps for when you actually have to:
* Go to https://release-monitoring.org/ and login. * Click add project in the navbar * Fill in the project name. You can use the upstream name or the Fedora package name here. * Fill in the homepage. This can be the project's website or just the Github page. * Select Github as the backend (or whatever is appropriate). * Select semantic as the Verison scheme. * Fill in owner/project * If it's a go project or another project that prefixes its tags with `v`, add that to Version prefix. * Select Check latest release on submit * Set the Distro to Fedora and put the name of the source package in Package. * Click the Test check button and make sure everything looks correct before submitting. - [ ] Add package to Koschei. 1. Go to https://koschei.fedoraproject.org and log in 2. Click on your username in the top right corner and click the `Add packages` button in the dropdown 3. Put the name of the source package (golang-gopkg-op-logging-1) in the names box and click `Add packages`.
The previous two tasks can be done any time, but the next two can only be done after the repo request goes through. - [ ] Give go-sig privileges on package 1. Go to https://src.fedoraproject.org/rpms/golang-gopkg-op-logging-1/addgroup 2. Put `go-sig` in the group name field and give it `commit` access. You can also add me as an admin if you'd like, but you don't have to for this package. - [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket. This is the same thing you did for your other two packages.
Thanks!