Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=767622
--- Comment #8 from Honza Horak hhorak@redhat.com 2012-01-06 03:21:38 EST --- (In reply to comment #5)
- the source archive is not compressed although it has .gz suffix, you can use
fedora-getsvn tool for grabbing the sources
Sources are grabbed with fedora-getsvn now.
- instead of using "cp" for installing files you should use either "cp -p" or
(better) "install -p -m 644", so the timestamp is kept for the files
"install -p -m 644" is used now.
- licenses as written in README and source files would be GPL+ and LGPL+
because no version is specified, included license texts are irrelevant here (see https://fedoraproject.org/wiki/Licensing/FAQ), clarification with upstream is required, ODBCTestQ4 seems to be GPLv2+, unixODBC library itself is LGPLv2+
Upstream points explicitly to GPL.txt/LGPL.txt files in source now, so GPLv3/LGPLv3 is used.
- passing --disable-static to configure should let only the shared libs build,
removing the need to "rm" them
Unneeded "rm" removed.
- rpmlint complains a bit:
unixODBC-gui-qt.x86_64: W: spelling-error Summary(en_US) plugins -> plug ins, plug-ins, plugging ... unixODBC-gui-qt.src: W: spelling-error %description -l en_US plugin -> plug in, plug-in, plugging => please fix
Fixed.
- shouldn't a devel subpackage exist? if not then the *.so links shouldn't be
packaged at all unixODBC-gui-qt.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libgtrtstQ4.so unixODBC-gui-qt.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libodbcinstQ4.so => see point above
See comment #6.
unixODBC-gui-qt-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/unixODBC-gui-qt/ODBCTestQ4/* => should be reported/fixed upstream
Reported upstream.
Spec URL: http://hhorak.fedorapeople.org/unixodbc-gui-qt/unixODBC-gui-qt.spec SRPM URL: http://hhorak.fedorapeople.org/unixodbc-gui-qt/unixODBC-gui-qt-0-0.3.2012010...