https://bugzilla.redhat.com/show_bug.cgi?id=1288739
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zbyszek@in.waw.pl Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review+
--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- No need to 'rm -rf build', %autosetup recreated the source directory anyway.
Please extend the %description... What is this software actually useful for, what does it do?
Seems to be missing BR: InsightToolkit-devel, gdcm-devel, fftw-devel, vxl-devel.
+ license is OK (ASL 2) + license file is present, %license is used + name is OK + latest version (git snapshot) + %check is present, some checks fail + builds and installs, binaries run
rpmlint: petpvc.src: E: summary-too-long C Toolbox for partial volume correction (PVC) in positron emission tomography (PET) petpvc.src: E: description-line-too-long C Toolbox for partial volume correction (PVC) in positron emission tomography (PET). petpvc.x86_64: E: summary-too-long C Toolbox for partial volume correction (PVC) in positron emission tomography (PET) petpvc.x86_64: E: description-line-too-long C Toolbox for partial volume correction (PVC) in positron emission tomography (PET). Please fix. Maybe "Toolbox for partial volume correction in positron emission tomography"?
petpvc.x86_64: W: no-manual-page-for-binary pvc_rl petpvc.x86_64: W: no-manual-page-for-binary pvc_mtc petpvc.x86_64: W: no-manual-page-for-binary petpvc petpvc.x86_64: W: no-manual-page-for-binary pvc_vc petpvc.x86_64: W: no-manual-page-for-binary pvc_iy petpvc.x86_64: W: no-manual-page-for-binary pvc_rbv petpvc.x86_64: W: no-manual-page-for-binary pvc_mg petpvc.x86_64: W: no-manual-page-for-binary pvc_diy petpvc.x86_64: W: no-manual-page-for-binary pvc_gtm petpvc.x86_64: W: no-manual-page-for-binary pvc_labbe petpvc.x86_64: W: no-manual-page-for-binary pvc_simulate 3 packages and 0 specfiles checked; 4 errors, 11 warnings.
OK.
Please fix the missing BR and summary and description when importing. Package is APPROVED.