[Bug 208034] Review Request: HippoDraw - Interactive and Python scriptable data analysis application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: HippoDraw - Interactive and Python scriptable data analysis application

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208034

------- Additional Comments From [e-mail]  2007-03-10 10:33 EST -------
Created an attachment (id=149772)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=149772&action=vie...)
mock build log of HippoDraw-1.19.4-1 on FC-devel i386

Okay, for 1.19.4-1:

* rpmlint issue
  - For binary:
-------------------------------------------------
W: HippoDraw-devel no-documentation
W: HippoDraw-python no-documentation
E: HippoDraw-python non-executable-script
/usr/lib/python2.5/site-packages/HippoDraw/pyfits.py 0644
-------------------------------------------------
   + The former two can be ignored.
   - About the last one: If this python script is only called by other
     python scripts and is not called directly by user, then please
     remove shebang.

* Requires
  - not fixed at all. Please check my previous comment 22.
    NOTE: Here what I mean is that you have to add something
    to "Requires", not "BuildRequires".

* Documentation
  - Still two files are under /usr/share/doc/HippoDraw/.
--------------------------------------------------
/usr/share/doc/HippoDraw/DISCLAIMER.rtf
/usr/share/doc/HippoDraw/LICENSE
--------------------------------------------------

* Desktop file
--------------------------------------------------
Categories=Science;DataVisualization;
--------------------------------------------------
  - Category "DataVisualization" is not valid (please check comment 25)
  - Category "Science" is valid, so this can be left as is.
    However, currenly no HippoDraw entry appear in my GNOME menu.
    Please check:
    /etc/xdg/menus/applications.menu 
    and add a category which can be found in the menu file above
    so that HippoDraw entry can appear on GNOME menu.

* Conditional dependency
  - Mock build log says:
----------------------------------------------------
checking for /usr/local/include/wcslib/wcs.h... no
checking for no/libwcs.a... no
configure: WARNING: WCSLIB not found
----------------------------------------------------
    - Perhaps this can be enabled by libwcs-devel?

* Build order
  - By the way, can it be moved to %build stage to
    make doxygen called to build documentation?

* Build log
  - Can the following(s) be ignored?
----------------------------------------------------
Generating docs for filRenderer type: "gif" not recognized. 
Use one of: canon cmap cmapx dia dot fig gtk hpgl imap ismap mif mp
pcl pdf pic plain plain-ext png ps ps2 svg svgz vtx xdot xlib
Problems running dot. Check your installation!
----------------------------------------------------

* Changelog
  - By the way, why do you use the mail address in the changelog
    which differs from your bugzilla entry?