https://bugzilla.redhat.com/show_bug.cgi?id=674008
Till Hofmann hofmann@kbsg.rwth-aachen.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hofmann@kbsg.rwth-aachen.de
--- Comment #103 from Till Hofmann hofmann@kbsg.rwth-aachen.de --- Hi everyone,
I'm picking up Tim's work from here (with Tim's consent). I'm not sure whether I should submit a new review request, so I'll add my comments here first.
SPEC: https://thofmann.fedorapeople.org/openrave.spec SRPM: https://thofmann.fedorapeople.org/openrave-0.9.0-4.20150624gitb32979b.fc20.s... patch0: https://thofmann.fedorapeople.org/openrave.pkgconfig.patch patch1: https://thofmann.fedorapeople.org/openrave.pyscript-permissions.patch
The new version contains the following changes: - update to a newer upstream version: Since the last release (0.9.0 from Oct 2012) a lot of fixes have been included, so it makes more sense to use the current git version instead of the last release - move documentantion into a separate doc package - fix AutoProvides and AutoRequires, which included openrave plugins - rename python package to python2-openrave, following the Python Packaging Guidelines (unfortunately, we cannot yet build a python3 package, because there is no python3 version of flann) - exclude arm from the supported architectures (upstream bug: https://github.com/rdiankov/openrave/issues/354) - clean up BR - split models into a separate noarch package
Since there is now a separate package for fparser, this package now uses that external fparser, which ships all headers needed to build openrave. Since fparser does not currently provide a cmake module, I've added a patch to find fparser using pkg-config. I've also sent the patch upstream: https://github.com/rdiankov/openrave/pull/352
The second patch contains a simple fix to make all installed python scripts executable. Also sent upstream: https://github.com/rdiankov/openrave/pull/353
We still use two 3rdparty libs: convexdecomposition and ivcon. ivcon is so small (two files) that I think it does not make sense to package it separately. I'm not sure how to proceed with convexdecomposition.
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10259352
rpmlint still gives some warnings:
openrave.x86_64: W: shared-lib-calls-exit /usr/lib64/libopenrave-core.so.0.9.0 exit@GLIBC_2.2.5 --> reported upstream: https://github.com/tpaviot/oce/issues/161
openrave.x86_64: W: no-documentation openrave-octave.x86_64: W: no-documentation openrave-models.noarch: W: no-documentation openrave-devel.x86_64: W: no-documentation --> separate doc package
openrave-devel.x86_64: W: only-non-binary-in-usr-lib --> symlink
openrave.x86_64: W: no-manual-page-for-binary openrave openrave-devel.x86_64: W: no-manual-page-for-binary openrave-config openrave-devel.x86_64: W: no-manual-page-for-binary openrave-createplugin.py --> no manpages provided by upstream.
openrave.x86_64: E: non-executable-script /usr/share/openrave/openrave.bash 0644L /bin/bash --> I *think* this script is only used to set up the environment, and should always be sourced. But this may actually need to be fixed.
Please let me know if I should submit a new review request.