[Bug 226453] Merge Review: system-config-boot

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: system-config-boot

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226453

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

------- Additional Comments From [e-mail]  2007-03-23 08:36 EST -------
> Minor: might include a copy of the GPL.

done
> Since redhat/fedora is upstream for this, can you make a note in the spec
>
> as suggested in:

http://www.fedoraproject.org/wiki/Packaging/SourceURL#head-413e1c297803cfa9d...

done
> I assume the reason it only builds on ix86/x86_64 is that it only understands
>
> lilo/grub? Might be worth filing a bug and noting it in the spec and see if
> some ppc folk are interested in contributing yaboot support.

what about sparc, s390 and the others?
> Please use one of the preferred buildroots, such as:
>
> %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

done
> Do not use %makeinstall. See:
>
> http://www.fedoraproject.org/wiki/PackagingDrafts/MakeInstall

done
> The desktop file is missing a valid Main Category, see:
>
> http://standards.freedesktop.org/menu-spec/latest/apa.html
> Suggest: System or Settings be added.
> Without this, this tool shows up under a "Other" menu in Xfce.

Categories=System;Application;SystemSetup;X-Red-Hat-Base;
> The buildrequires are not all needed, suggest changing:
>
> BuildRequires: python >= 0:2.2, perl, gettext, glibc-devel, gcc,
> desktop-file-utils, yelp, perl-XML-Parser

done
> Shouldn't the firstboot package own
>
> %dir /usr/share/firstboot/
> %dir /usr/share/firstboot/modules
> and not this package?

done
> 2 outstanding bugs. Might look if either can be resolved easily.

bug #134548 and bug #181749 are not easily fixable
> rpmlint says:
>
> a) E: system-config-boot no-binary
> I assume this is not noarch since it can be only run on ix86/x86_64?

yep
> b)
> W: system-config-boot conffile-without-noreplace-flag 
> /etc/pam.d/system-config-boot
> W: system-config-boot conffile-without-noreplace-flag
> /etc/security/console.apps/system-config-boot
> Suggest: should those be (noreplace)?

done
> c) W: system-config-boot no-documentation 
> No docs available?

no .)
> d)
> Suggest: remove the #!/usr/bin/python from those.

done
> e) W: system-config-boot unversioned-explicit-obsoletes redhat-config-boot
> Suggest: add a version here? or just remove it at this point?

added version
> f)
> W: system-config-boot rpm-buildroot-usage %prep rm -rf $RPM_BUILD_ROOT
> E: system-config-boot no-cleaning-of-buildroot %install
> Suggest: Move the rm from prep to the top of install?

done
> g)
> W: system-config-boot macro-in-%changelog dist
> W: system-config-boot macro-in-%changelog dist
>
> Suggest: Change occurances of %dist in the changelog with %%dist

done
> h) E: system-config-boot-debuginfo empty-debuginfo-package
> I guess you need to add
>  %define debug_package %{nil}
> if this really has to be an arch package.

done

please check system-config-boot-0.2.15-1.fc7