Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qsa: Qt Script for Applications
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191589
------- Additional Comments From rdieter@math.unl.edu 2006-06-08 16:02 EST ------- Learned something cool today about qmake, you may want to consider this cleaner/simpler method of determining QTDIR, QTINC, QTLIB:
%define qtdir %(qmake4 -query QT_INSTALL_PREFIX) %define qtinc %(qmake4 -query QT_INSTALL_HEADERS) %define qtlib %(qmake4 -query QT_INSTALL_LIBS)
re: rpmlint A couple of things: 1. make sure %defattr is *first*, so %files should be: %files %defattr(-,root,root) ...
2. why in -devel %defattr(755,root,root) instead of %defattr(-,root,root)?
3. Re: wrong-file-end-of-line-encoding, --hidden-file-or-dir warnings. IMO, these are small-potatoes. You can fix these if you want, but it's not a blocker.