https://bugzilla.redhat.com/show_bug.cgi?id=839649
Michal Fojtik mfojtik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mfojtik@redhat.com
--- Comment #1 from Michal Fojtik mfojtik@redhat.com --- Review:
- Summary && %description should start with the capital 'A' - No tests
Please check if those tests are not included in gem, if so, I would ask upstream to add them. But not a review-blocker:
https://github.com/railsbp/rails_best_practices/tree/master/spec
- The list of files in the %files section looks a bit ugly, it is possible to somehow compress it? Like using directories rather than listing all files?
- Please exclude the '.yardoc/*' files, then are not needed for the gem
- Also consider removing this files:
%{gem_instdir}/.gemtest %{gem_instdir}/.gitignore %{gem_instdir}/.rspec %{gem_instdir}/.rvmrc %{gem_instdir}/.travis.yml %{gem_instdir}/Gemfile %{gem_instdir}/Gemfile.lock %{gem_instdir}/Guardfile
- The MIT_LICENSE should go into main %files section - I also think the 'License: GPLv2+ or Ruby' is wrong, since the license seems to be MIT.