https://bugzilla.redhat.com/show_bug.cgi?id=1350029
--- Comment #16 from Jarod Wilson jarodwilson@gmail.com --- (In reply to Igor Gnatenko from comment #15)
Unfortunately it's not yet good package.
%defattr(-,root,root,-)
MUST be dropped
This isn't a "MUST" from my reading of things.
%clean rm -rf %{buildroot}
MUST be dropped
This is under "SHOULD" in the packaging guidelines, not "MUST".
make %{?_smp_mflags}
COULD be replaced iwth %make_build
make DESTDIR=%{buildroot} install
COULD be replace with %make_install
Potayto, potahto.
%setup -q -n %{name}-%{version}
COULD be changed to %setup -q or to %autosetup
I did miss this one, could easily be just %setup -q, since '%{name}-%{version}' is already the default name things are expected to be in, but I wouldn't consider this a blocking issue. Easily fixed in the next bump.
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
MUST be dropped
Also a "SHOULD", not a "MUST".
Group: System Environment/Libraries Group: System Environment/Libraries
COULD be dropped
%package devel-static
It's actually not devel-static, but just static. Please adjust.
Take a look at every other libibverbs hardware driver (libocrdma, libcxgb4, libmlx5, etc), this is how all of them look. This is following precedent.