Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: indent
https://bugzilla.redhat.com/show_bug.cgi?id=225899
mlichvar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE Flag|fedora-review? |fedora-review+
------- Additional Comments From mlichvar@redhat.com 2008-03-12 13:22 EST ------- OK: - rpmlint is silent - the package is named according to the Package Naming Guidelines - the spec file name matches the base package %{name} - the package is licensed with a Fedora approved license - the License field in the package spec file matches the actual license (GPLv3+) - the spec file is written in American English - the spec file for the package is legible - the sources used to build the package matches the upstream source - all build dependencies are listed in BuildRequires - the spec file handles locales properly - the package owns all directories that it creates - the package does not contain any duplicate files in the %files listing - permissions on files are set properly - the package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT - the package consistently uses macros - the package contains code, or permissible content - files included as %doc don't affect the runtime of the application - the package does not own files or directories already owned by other packages - at the beginning of %install, the package runs rm -rf $RPM_BUILD_ROOT - all filenames in the package are valid UTF-8 - scriptlets are sane
Approved.