Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cel - Crystal Entity Layer Alias: cel
https://bugzilla.redhat.com/show_bug.cgi?id=432034
------- Additional Comments From chris.stone@gmail.com 2008-03-09 15:25 EST ------- ==== REVIEW CHECKLIST ==== - rpmlint output See comment #4 - package named according to package naming guidelines - spec file name matches %{name} - package meets packaging guidelines - package licensed with a fedora approved license - license matches actual license X license file not included in %doc - spec file written in American English - spec file legible - source match upstream fafcd7c049d23d43efd8f7de465c6496 cel-src-1.2.tar.bz2 - successfully compiles on x86_64 F-8 - all build dependencies listed in BR - no locales X does not call ldconfig in %post/%postun (see comment #9) - package is not relocatable - package owns all directories it creates - no duplicates in %files - contains proper %clean - macro usage is consistent - contains code - large documentation in doc subpackage - files in %doc do not affect runtime - header files located in devel subpackage - no static libs - no pkgconfig files - no library files with suffix - devel subpackage requires base package - no libtool archives - not a GUI application - package does not own files or directories owned by other packages - buildroot removed on %install - filenames UTF-8
==== MUST FIX ==== - Include license in %doc - Add %post/%postun sections which run ldconfig
==== SHOULD FIX ==== - Investigate if other files should be placed in %doc - Test for crashes and success in demo programs