https://bugzilla.redhat.com/show_bug.cgi?id=1262552
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #7 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- (In reply to Kevin Fenzi from comment #6)
ok. I created the python2 subpackage.
Can you explain how run.sh in Tests is broken? It worked fine here, but note (as per the comment in the spec file) it's commented out because you have to have a YubiHSM to test against.
$ /usr/share/doc/python2-pyhsm/Tests/run.sh python: can't open file '/usr/share/doc/python2-pyhsm/Tests/../setup.py': [Errno 2] No such file or directory
It also refers to ../Lib, which is not in the package at all.
Is there a guideline saying to replace all /usr/bin/env calls? I agree it's not great, but I would prefer to ask upstream to change that instead of carrying some large patch.
Some executables in the package in /usr/bin/ have /usr/bin/env python, others have /usr/bin/python. This is kind of inelegant. Also there's bigger chance of running a user-installed python by mistake. Changing it to /usr/bin/python2 everywhere makes things crystal clear. I don't think that there's an official guideline, but I think it's generally recommended.
Spec URL: https://www.scrye.com/~kevin/fedora/review/python-pyhsm/python-pyhsm.spec SRPM URL: https://www.scrye.com/~kevin/fedora/review/python-pyhsm/python-pyhsm-1.0.4l- 3.fc24.src.rpm
OK, please fix (or not) the two small issues pointed out above as you see fit. Package is APPROVED.