Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513497
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@bernewireless.net
--- Comment #1 from Fabian Affolter fabian@bernewireless.net 2009-07-24 11:19:56 EDT --- Just some comments after a quick look at your spec file:
- You are mixing '%{buildroot}' and '$RPM_BUILD_ROOT'
https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D... Please take a look at https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
- The man pages are automatically compressed by RPM
- README and COPYING must be added to the %files section. https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25files_prefixe...
- Isn't %configure instead of ./configure working? https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25build_section
- Aren't gtk2, gtk-vnc, and gnutls automatically picked up by RPM?