https://bugzilla.redhat.com/show_bug.cgi?id=1397784
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #1 from Rex Dieter rdieter@math.unl.edu --- naming: ok
license: ok
sources: ok (for now, 5.7.1 tarballs not officially released yet)
macros: ok
scriptlets: ok
follows style/conventions of other qt5- packages
Same comments as some other qt5- related reviews,
1. MUST reivew (and remove if needed) hard qt5 versioned dep, %{?_qt5:Requires: %{_qt5}%{?_isa} = %{_qt5_version}}
2. SHOULD remove BuildRequires: cmake it's not needed anymore, the appropriate cmake is pulled in by qt5-rpm-macros
APPROVED