https://bugzilla.redhat.com/show_bug.cgi?id=2161003
--- Comment #2 from Jakub Kadlčík jkadlcik@redhat.com --- Hello @lichaoran, thank you for the package.
Bug 2161003 - Review Request: pyjwkest - dependency of pyoidc library
Can you please update the summary and put the package summary instead of "dependency of pyoidc library"?
# Check if the automatically generated License and its spelling is correct for Fedora # https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline... License: ASL
I guess that's an autogenerated comment telling you to check if the ASL is a correct license name according to Fedora guidelines. Please do so :-)
Please take a look here https://docs.fedoraproject.org/en-US/legal/allowed-licenses/ and use the SPDX expression for the exact ASL version.
Then you can remove the autogenerated comment.
This is up to you, I don't see it as a blocker but I am confused where the source code lives. Because the PyPI page doesn't show any project homepage.
I think it is this project? https://github.com/IdentityPython/pyjwkest
The homepage URL was added in https://github.com/IdentityPython/pyjwkest/commit/dde43072349917ba1f94c8962f...
but there is a total mess in versions. The last release on GitHub is 1.4.0, the version on PyPI says 1.4.2, and in src/jwkest/__init__.py there is 1.4.3 . Can you please ask/help the maintainer to sort this out?
# Fill in the actual package description to submit package to Fedora %global _description %{expand: This is package 'pyjwkest' generated automatically by pyp2spec.}
Can you please write two or three sentences about the package and then remove the comment?
# For official Fedora packages, including files with '*' +auto is not allowed # Replace it with a list of relevant Python modules/globs and list extra files in %%files %pyproject_save_files '*' +auto
As the comment says, '*' is not allowed for official Fedora packages. Instead, you should change it to the package name. If you do `import foo` to use the package, then the value is 'foo'.
Issues:
- Spec file name must match the spec package %{name}, in the format %{name}.spec. Note: pyjwkest.spec should be python-pyjwkest.spec See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_spec_file_naming
The fedora-review tool also found this error. Your spec should be named python-pyjwkest.spec