Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=458655
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com AssignedTo|nobody@fedoraproject.org |panemade@gmail.com
--- Comment #1 from Parag AN(पराग) panemade@gmail.com 2008-08-13 04:23:04 EDT --- Review: + package builds in mock (rawhide i386). http://koji.fedoraproject.org/koji/taskinfo?taskID=774918 + rpmlint is silent for SRPM and for RPM. + source files match upstream url ae0d69a743bc52a169dea6a07c301e06 Text-Table-1.114.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=2, Tests=166, 0 wallclock secs ( 0.03 usr 0.00 sys + 0.10 cusr 0.01 csys = 0.14 CPU) + Package perl-Text-Table-1.114-1.fc10 -> Provides: perl(Text::Table) = 1.114 Requires: perl(Carp) perl(Exporter) perl(Text::Aligner) perl(strict) perl(warnings)
APPROVED.