Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hydrogen - Advanced drum machine
https://bugzilla.redhat.com/show_bug.cgi?id=190040
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|seg@haxxed.com |j.w.r.degoede@hhs.nl
------- Additional Comments From j.w.r.degoede@hhs.nl 2007-10-08 10:45 EST ------- Taking over as reviewer, since Callum is very busy with other stuff ATM AFAIK. I hope you don't mind Callum.
Full review done (sources match upstream, license ok, everything else also checked), I've found a few items to fix:
MUST FIX -------- - You currently pass LIBDIR=%{_libdir} to make but not to make install! I couldn't test this at a 64 bit machine atm, but either you should use it in both places or not all - Remove these obsolete or unneeded options when installing the .desktop file: --add-category X-Fedora \ --add-category AudioVideo \ --add-category Application \ - Add the following to remove the obsolete Application category that is in upstreams .desktop file: --remove-category Application \ - Remove "MimeType=text/xml" from hydrogen.desktop, thats way too generic! - Remove obsolete "Version=1.0" from hydrogen.desktop - No longer run update-desktop-database from %post[un] now the .desktop file no longer defines a MimeType - The update icon cache scriptlets should check the existence of gtk-update-icon-cache before calling it, see: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-7103f6c38d1b5...
SHOULD FIX ---------- - Add the following Categories from: http://standards.freedesktop.org/menu-spec/latest/apa.html : Midi - Add the following X-foo categories, to mathc what CCRMA has so that this package will work with CCRMA's nested audio utilities menus: X-Drumming X-MIDI X-Jack