Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-HTTP-Upload - Secure managment of files submitted via HTML Forms Alias: pear-HTTP-Upload
https://bugzilla.redhat.com/show_bug.cgi?id=397031
fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From fedora@famillecollet.com 2007-12-22 04:22 EST ------- REVIEW:
* rpmlint : OK * The package is named according to the Package Naming Guidelines. * The spec file name match the base package * The package follow the PHP Packaging Guidelines * Fedora approved license (LGPL) * License field in the package spec file match the actual license * The spec file is written in American English * The spec file is legible * The sources used to build the package must match the upstream source fd1161202786fcba5272d2715bcda787 HTTP_Upload-0.9.1.tgz * build in mock (F-7, noarch) * All build dependencies are listed in BuildRequires * no locales * no shared library files * package own all directories that it creates * Package don't own files or directories already owned by other packages (HTTP owned by php-pear-HTTP-Request, but no dependencies, so it's ok) * no duplicate files * Permissions on files are set properly * %clean section * package consistently use macros * The package contain code * small documentation * no library * no desktop file * %install, start with rm -rf %{buildroot} * All filenames are valid UTF-8 * scriptlets are sane* * Final Provides ok php-pear(HTTP_Upload) = 0.9.1 php-pear-HTTP-Upload = 0.9.1-1.fc8 * Final Requires see below /usr/bin/pear php-pear(PEAR)
Should : see previous comment
APPROVED