https://bugzilla.redhat.com/show_bug.cgi?id=2181020
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com Doc Type|--- |If docs needed, set a value Status|NEW |ASSIGNED Flags| |fedora-review? Assignee|nobody@fedoraproject.org |decathorpe@gmail.com
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Package looks good, with two exceptions:
1. Both the MIT and Apache-2.0 licenses require that redistributed sources contain a copy of the license text, but the published crates for the cargo_toml crate do not contain license texts (this is why there's a FIXME in the generated spec file).
Looking at the upstream project, there's also no license files there: https://gitlab.com/crates.rs/cargo_toml
Please report this with the upstream project. They should include license files, otherwise their own project isn't conforming to the license(s) they chose :)
I've already filed similar issues with dozens of other projects ... for example, you can take this one as a template: https://github.com/danieldg/ordered-stream/issues/1
2. The latest version is 0.15.2, but you're packaging 0.13.3. I assume this is intentional (i.e. firecracker depends on ^0.13?)? If that is the case, just confirm this in this bug here. This is enough of a justification to not package the latest version.