https://bugzilla.redhat.com/show_bug.cgi?id=2356940
Alex Haydock alex@alexhaydock.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |alex@alexhaydock.co.uk
--- Comment #3 from Alex Haydock alex@alexhaydock.co.uk --- Hi!
I tried taking a look at this package as a non-binding review. I am not a Fedora Packager yet, but as part of the pre-requisites to become one I am trying to review existing packages in the queue to get familiar with the basics and some of the philosophy behind various design decisions.
I spotted a few things so far in the current SPEC:
The line: ``` %global debug_package %{nil} ```
Should not be needed as the package is a `noarch` package without any ELF objects with debuginfo, so there can be no debuginfo.
The `-p` flag should be used for `install` arguments to preserve timestamps, e.g.:
``` install -Dpm755 bootmac -t %{buildroot}%{_bindir}/ ```
At a package level, I'm not too familiar with the codebase here but I'm wondering if there's a particular reason why the `bootmac-wifi.rules` from upstream have been included, but the `bootmac-bluetooth.rules` equivalent for Bluetooth has not?