Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=675726
--- Comment #6 from Peter Lemenkov lemenkov@gmail.com 2011-02-08 07:42:53 EST --- Few notes before review:
* Please, drop commented out lines in the %install section
* Drop the following line as well
install -Dm644 src/xinitrc.skel $RPM_BUILD_ROOT/%{_docdir}/%{name}-%{version}/xinitrc.example
this file should be installed just as other docs (mark it as %doc in the %files section).
* The directory %{_datarootdir}/%{name}/ left unowned. Please apply the following change:
- %{_datarootdir}/%{name}/* + %{_datarootdir}/%{name}/
Note - trailing asterisk was removed.