Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=473590
--- Comment #3 from Peter Robinson pbrobinson@gmail.com 2008-12-01 16:42:40 EDT --- (In reply to comment #1)
- Meets Packaging Guidelines. - ***
Summary should probably drop the leading 'A'.
Will do
You appear to be packaging a git snapshot. (In fact, you're including the entire .git directory in the tarball, which isn't really needed.)
Please see https://fedoraproject.org/wiki/Packaging/SourceURL for how to handle this, and how to version the package.
I missed that. Will update it.
- License - LGPLv2+ - OK
- License field in spec matches - ***
"GPLv2+ and LGPLv2+"
I don't actually see any GPLv2+ code in the tarball.
There was a COPYING and COPYING.LESSER file included which is why I marked it as such. If you think the COPYING file is irrelevant.
- License file included in package - OK
- Spec in American English - OK
- Spec is legible. - OK
- Sources match upstream md5sum: - ***
See above re: snapshot packaging.
ACK.
- Should package latest version - ***
See above re: source control pulls.
ACK.
So, for approval:
- fix %{version} and source control URL to specify what revision you're pulling
- fix License: tag
- maybe tweak summary
If this is going to change ABI frequently without changing soname, a warning in the -devel package might be nice. Then again, if nothing other than the FUSE client is going to use the library, it may not be relevant.
Would the warning be contained in an included text file or in the description or somewhere else? I'm not sure whether the library would be used by conduit or rhythmbox or whether they'd use the ifuse client.
I'll update the file with the suggestions at update the ticket once complete.