https://bugzilla.redhat.com/show_bug.cgi?id=2132701
--- Comment #2 from Petr Pisar ppisar@redhat.com --- (In reply to Benson Muite from comment #1)
- Package contains the mandatory BuildRequires and Requires:. Note: Explicit dependency on perl-devel is not allowed See: https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/
fedora-review lies. A build-time dependency on perl-devel is perfectly fine. It must be there because the package builds an XS Perl module, a module written in C which includes Perl header files and which links to libperl.so library. The guidelines says so https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/#_build_dependencies.
- systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in libloc-tools See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_scriptlets
Thanks for noticing it. I though that systemd sciptlets were already replaced with file triggers. I added the scriptlets.
Unversioned so-files
perl-libloc: /usr/lib64/perl5/vendor_perl/auto/Location/Location.so python3-libloc: /usr/lib64/python3.11/site-packages/_location.so
This is another imperfection of fedora-review. Both files are plugins into the respective language interpreters, installed into a path not known to a dynamic linker. Both Perl and Python expect unversioned SO files.
An updates spec file is located on the same address.