https://bugzilla.redhat.com/show_bug.cgi?id=915791
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #21 from Petr Šabata psabata@redhat.com --- (In reply to Petr Pisar from comment #19)
(In reply to Petr Šabata from comment #18)
- Several of the listed build dependencies don't appear to be used at build time, including:
- perl(DBD::SQLite)
This is used when running t/store-sqlite.t.
Ok, I thought you weren't running the test, probably due to the comment in %check.
- perl(Fcntl)
Removed.
- perl(Perlbal)
Removed.
- perl(Perlbal::Socket)
Removed.
- perl(Perlbal::TCPListener)
Removed.
- net-tools
Removed.
Ack.
- You could use the NO_PACKLIST feature.
Done.
You should also update the EE::MM dependency to require >= 6.76, which is the version which introduced this feature.
- mogstored is missing some runtime dependencies, namely:
- perl(Mogstored::ChildProcess::DiskUsage)
Added.
- perl(Mogstored::ChildProcess::IOStat)
Added.
- perl(Pod::Usage)
Added.
Ack.
- Does it make sense to have the None backend in a separate subpackage?
For the symmetry.
Ok.
- To me, "Same terms as Perl itself. Artistic/GPLv2, at your choosing" doesn't read as "(GPL+ or Artistic) and (GPLv2 or Artistic)" but more like "GPL+ or GPLv2 or Artistic".
I can see your point. My reading of the second sentence is this is an explanation (a wrong one) of the first sentence.
Your reading can be simplified to "GPL+ or Artistic". My reading can be simplified to "GPLv2 or Artistic".
I will use stricter "GPLv2 or Artistic" that conform to both readings and I will try to ask the author.
Clarified with the next update.
Spec URL: https://ppisar.fedorapeople.org/perl-MogileFS-Server/perl-MogileFS-Server. spec SRPM URL: https://ppisar.fedorapeople.org/perl-MogileFS-Server/perl-MogileFS-Server-2. 72-1.fc27.src.rpm
No blockers here. Approving.