Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=598299
Adel Gadllah adel.gadllah@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |adel.gadllah@gmail.com Flag| |fedora-review?
--- Comment #1 from Adel Gadllah adel.gadllah@gmail.com 2010-06-01 07:55:53 EDT --- (In reply to comment #0)
Spec URL: http://sundaram.fedorapeople.org/packages/systemd.spec SRPM URL: http://sundaram.fedorapeople.org/packages/systemd-0-0.0.20100602git.src.rpm
Description: Systemd is a system and session manager compatible with SysV init and LSB init script headers. Systemd has aggressive parallelization capabilities, uses D-Bus activation for starting services and keeps track of processes using cgroups.
--
This will only build on rawhide due to the build requirements, in particular udev needs to be a higher version than what is in F-13. I am filing this review request on behalf of Lennart since he isn't keen on packaging. I have confirmed that it is ok by him. I will add him as the primary maintainer once the review process is over.
OK here are some initial comments:
1) Does not build in rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=2221974 2) No %clean 3) Missing instructions on how the tarball was generated 4) Please add an abbreviated git commit id to the release (date is not unique) 5) "%{_mandir}/man?/*.[0-9]* " no need for using fancy regex here 6) rpmlint output: ------ systemd.src: W: spelling-error %description -l en_US init -> unit, int, nit systemd.src: W: spelling-error %description -l en_US parallelization -> parallelism, parallelogram, channelization systemd.src: W: spelling-error %description -l en_US cgroups -> groups, c groups, Citigroup systemd.src:16: W: macro-in-comment %{name} systemd.src:16: W: macro-in-comment %{version} systemd.src:49: E: hardcoded-library-path in /lib/systemd/ systemd.src: W: no-cleaning-of-buildroot %install systemd.src: W: no-cleaning-of-buildroot %clean systemd.src: W: no-buildroot-tag systemd.src: W: no-%clean-section systemd.src: W: invalid-url Source0: systemd-2010-06-02.tar.xz -------
Can be mostly ignored.
No full review possible due to build failure. I will do a proper review once you fix the noted issues and the build.