Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: griv - a gtk rivchat
https://bugzilla.redhat.com/show_bug.cgi?id=454166
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-07-21 11:00 EST ------- Created an attachment (id=312268) --> (https://bugzilla.redhat.com/attachment.cgi?id=312268&action=view) Patch to honor Fedora cflags correctly
For 0.1.9-2:
* License - License tag should be "GPLv3".
* BuildRequires - Please don't write "perl-devel" as BuildRequies Instead please use module name virtual Provides the needed rpms Provide: https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides
* CFLAGS - Fedora specific compilation flags are not correctly passed yet: http://koji.fedoraproject.org/koji/getfile?taskID=729334&name=build.log (Parent task: http://koji.fedoraproject.org/koji/taskinfo?taskID=729331 ) Makefiles in the tarball is wrong. Please apply the patch attached and remove extra lines ------------------------------------------------------------- CFLAGS="${CFLAGS:-$RPM_OPT_FLAGS}" export CFLAGS ------------------------------------------------------------- ! Note These 2 lines should not be needed anyway. You can check what %configure actually does by $ rpm --eval %configure
* icons - Please verify if installing a icon into %{_datadir}/icons/hicolor/22x22/apps is really needed. The same icon is already installed under %{_datadir}/pixmaps/.
* Documents - Please add the following files to %doc. ------------------------------------------------------------- AUTHORS Changelog -------------------------------------------------------------