Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=736163
--- Comment #4 from Bojan Smojver bojan@rexursive.com 2011-09-11 20:25:19 EDT --- (In reply to comment #2)
- SRPM spec file differs from standalone spec file (File in SRPM misses the
disttag)
Corrected. Must have copied an older copy of the spec file out by accident.
- BuildRoot, %clean and rm -rf $RPM_BUILD_ROOT (in %install) can be removed
(unless you want to get this package into EPEL too)
It doesn't hurt and we may do an EPEL package, so I'll let it stay for now.
- The upstream makefile ignores the $RPM_OPT_FLAGS. It should be patched to
correctly set the compiler flags.
Should be fixed here:
ftp://ftp.rexursive.com/pub/gobi_loader/gobi_loader.spec ftp://ftp.rexursive.com/pub/gobi_loader/gobi_loader-0.7-3.fc15.src.rpm
Once again, thank you for your contribution.