Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469291
Till Maas opensource@till.name changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |opensource@till.name Status Whiteboard| |NotReady Flag| |needinfo?(paul@xelerance.co | |m)
--- Comment #8 from Till Maas opensource@till.name 2008-12-10 16:13:02 EDT --- - RPM_OPT_FLAGS are not honoured: https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags E.g.:
cc -g -Wall -DTUNTAP -c -o ethertap.o ethertap.c
- It does not build here, the Makefile of humsify contains:
install -o 0755 $(BIN) $(DESTDIR)$(BIN_DIR)
The "-o 0755" should probably be "-m 0755", which then can be omitted, because it is the default mode used by install.
Please make sure that the package builds before submitting it for review. You can use:
koji build --scratch dist-f11 *.src.rpm
To create a scratch build of the package on koji to verify that it builds.
Please remove the "NotReady" from the Whiteboard once you submitted a SRPM that does at least build.