Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=515230
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp Flag| |fedora-review?
--- Comment #5 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-11-24 12:19:07 EDT --- Some notes:
* %define -> %global - Now Fedora prefers to use %global instead of %define:
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over...
* Source - Source0 in your srpm differs from what I could download from the URL written as %SOURCE0: --------------------------------------------------------------- 97986 2009-09-23 18:24 python-dmidecode-3.10.7.tar.gz 97487 2009-09-23 18:25 python-dmidecode-3.10.7-1.fc11.src/python-dmidecode-3.10.7.tar.gz ---------------------------------------------------------------
* Requires - (Here I am speaking of Requires, not BuildRequires) dmidecode.py contains: --------------------------------------------------------------- 28 import libxml2 29 from dmidecodemod import * --------------------------------------------------------------- This means that this package should have "Requires: libxml2-python".
* Parallel make - Support parallel make if possible: https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make
* Macros - Use macros properly. /usr/share should be %{_datadir}. https://fedoraproject.org/wiki/Packaging/RPMMacros
* Directory ownership issue - The directory /usr/share/python-dmidecode/ must be owned by this package:
https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Owner...