https://bugzilla.redhat.com/show_bug.cgi?id=1279176
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #4 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- (In reply to Igor Gnatenko from comment #2)
- Why is -applications and -tools seperate?
-applications requires very big dependency: muParser
muParser is 120k RPM, 369k installed. I wouldn't bother with the split, but if you want to ... OK.
- license is OK (GPLv3+) - license file is present, %license is used - license is present for any subpackage combination - latest version - requires / provides look mostly correct (see below) - builds and installs OK - applications run - rpmlint:
isis.i686: W: incoherent-version-in-changelog 0.7.9-1 ['0.7.9-2.fc24', '0.7.9-2'] Please fix.
isis-devel.i686: E: incorrect-fsf-address /usr/include/isis/CoreUtils/application.hpp isis-adapter-itk-devel.i686: E: incorrect-fsf-address /usr/include/isis/Adapter/itkAdapter.hpp isis-adapter-itk-devel.i686: E: incorrect-fsf-address /usr/include/isis/Adapter/itkAdapter_impl.hpp You should ping upstream about that.
Issues: isis-adapter-qt4-devel should have: Requires: isis-adapter-qt4{?_isa} = %{version}-%{release}
isis-adapter-itk-devel likewise.
There seems to be a problem with one of the plugins: $ isisdump ... ImageIO:warning["io_factory.cpp":202] Could not load library "/usr/lib64/isis/plugins/libisisImageFormat_png.so":"/usr/lib64/isis/plugins/libisisImageFormat_png.so: undefined symbol: png_set_longjmp_fn"
This seems to be a problem with libpng version. According to http://stackoverflow.com/a/21588966 libpng >= 1.4 has this function, but libisisImageFormat_png.so links to libpng 1.2. And you have BR:libpng12-devel. Please investigate!
OK, some trivial fixes and some bugfixing is needed, but nothing to hold up the review. Package is APPROVED.