Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: griv - a gtk rivchat
https://bugzilla.redhat.com/show_bug.cgi?id=454166
------- Additional Comments From wolfy@nobugconsulting.ro 2008-07-21 11:55 EST -------
Would you check my comment?
I apologize, I have started the review quite early today but I have been interrupted by $RegularWork. Before I had the chance to come back to the review in order to end it, you have replied and assigned the bug to yourself.
Why? Unless using "--delete-original", this is needed (if --vendor fedora is
specified) Because either --delete-original in desktop-file-install or an exclude line in %files can be used
- please use either RPMBUILDROOT or rpmbuildroot, but not both
Where is it used?
desktop-file-install --vendor="fedora" \ --dir=$RPM_BUILD_ROOT%{_datadir}/applications \ %{buildroot}/%{_datadir}/applications/%{name}.desktop
(obviously, in #8 I meant %buildroot not rpmbuildroot )