https://bugzilla.redhat.com/show_bug.cgi?id=1344276
Sachidananda Urs surs@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |surs@redhat.com
--- Comment #5 from Sachidananda Urs surs@redhat.com --- (In reply to Ken Dreyer from comment #4)
Would you please address each of Parag's comments above and update the package to the latest upstream version?
Ack! I will do that.
I'm a sponsor, so I can sponsor you if you would please do one satisfactory unofficial review of a package in Parag's links above, and ensure that this package gets cleaned up.
Sure, I will do that. Thanks for this.
For example, this sort of boilerplate seems common in the Gluster community and is unneeded:
%define name gdeploy %define version 2.1 %define release 0
In fact it will break tools like rpmdev-bumpspec that Fedora rel-eng uses for mass rebuilds. It's better to simply define the values directly in the RPM:
Name: gdeploy Version: 2.1 Release: 1%{?dist}
The URL should be the upstream project, https://github.com/gluster/gdeploy, not Red Hat's storage website.
Sure. I will make these changes. Thanks for helping on this.