https://bugzilla.redhat.com/show_bug.cgi?id=1573778
Robert-André Mauchin <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zebob.m(a)gmail.com
--- Comment #2 from Robert-André Mauchin <zebob.m(a)gmail.com> ---
- GPL-3.0 is not a valid license shorthand. See the list
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses
License: GPLv3
- Simplify Source0:
Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz
- Probably not needed:
Requires: glibc openssl-libs tomsfastmath libtomcrypt
The library dependencies will be picked up automatically.
- The following could be simplified into: %autosetup -p1
%setup -q
%patch0 -p1
%patch1 -p1
- Use the %{_prefix} macro:
%make_install PREFIX="%{_prefix}"
- Use * instead of specifying .gz as the compression might change in the
future:
%{_mandir}/man1/pixiewps.1.*
- The description should be split to stay below 80 characters per line:
%description
Pixiewps is a tool written in C used to bruteforce offline the WPS PIN
exploiting the low or non-existing entropy of some software implementations,
the so-called "pixie-dust attack" discovered by Dominique Bongard in summer
2014.
- Patch the Makefile in %prep to keep the timestamps:
sed -i "s|^\tinstall -|\t\$(INSTALL) -|" Makefile
The Makefile will use the $(INSTALL) variable defined by %make_install to
keep the timestamps.
- You haven't build tomsfastmath for Rawhide and F28 which is not good and it
prevents building this package:
https://src.fedoraproject.org/rpms/tomsfastmath
http://koji.fedoraproject.org/koji/search?type=package&match=glob&...
You should always build for Rawhide first, and then git merge into the other
branches.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component