https://bugzilla.redhat.com/show_bug.cgi?id=1922869
--- Comment #8 from Neal Gompa ngompa13@gmail.com --- (In reply to Carl George 🤠 from comment #6)
Outstanding items to fix:
- %_distconfdir still needs to be removed.
Done.
- License breakdown comment is inaccurate.
Done.
- fedora-review complains about an obsolete m4 macro (AC_PROG_LIBTOOL) in
configure.ac, line 40
Done. Submitted fix upstream: https://github.com/openSUSE/transactional-update/pull/54
- tukit links against libtukit.so.0, so the explicit requirement on
tukit-libs is not necessary.
This is a common thing done in Fedora when you want to guarantee they're updated together, especially as I don't know what the interface boundaries are for tukit with libtukit, so I prefer to keep the explicit dependency.
- %systemd_postun evaluates to %nil, should that be
%systemd_postun_with_restart? If not then consider just removing %post -n tukit, as it's causing an rpmlint warning.
I removed the scriptlet to resolve this.
There are two other rpmlint warnings that I'm not sure about, if you know a way to clear them up we should try to do that.
- dracut-transactional-update.noarch: W: only-non-binary-in-usr-lib
- tukit-libs.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libtukit.so.0.1.0 /lib64/libm.so.6
No idea how to deal with this.