https://bugzilla.redhat.com/show_bug.cgi?id=1717389
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com
--- Comment #5 from Neal Gompa ngompa13@gmail.com --- 1. "%{rpmmacrodir}" is undefined. It's "%{_rpmmacrodir}": https://github.com/rpm-software-management/rpm/blob/master/macros.in#L141-L1...
2. Please include a license file, because other distros will copy these macros (Mageia and OpenMandriva, for example, source from us) and it's easier to comply with licenses when they exist in the source tree.
3. Please use "python3dist(pip)" or "python3-pip" instead of "pip" as a dependency. "pip" doesn't exist.
4. The %build section sets up %_builddir and %_buildsubdir, so don't drop it, just put a comment indicating there's nothing to do there.