Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libscigraphica - A library of gtk+ widgets for SciGraphica
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220967
------- Additional Comments From paul@all-the-johnsons.co.uk 2006-12-31 08:33 EST ------- Builds cleanly in mock rpmlint is quiet (warning on the devel package, but it can be ignored)
Review
Bad: Release: 2 - must have the .%{?dist} tag Requires: %name = %{version}-%{release} - inconsistent naming - should be %{name} %{_libdir}/scigraphica/ - this takes the ownership of the directory which should be owned by scigraphical
Good: UTF-8, American English, contains documentation for the main package pkgconfig in R for the -devel package MD5SUM matches upstream No .la or .a files packaged
Unsure: Does the -devel need ldconfig to be run?